Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all code #29

Closed
wants to merge 5 commits into from
Closed

Refactor all code #29

wants to merge 5 commits into from

Conversation

bmesuere
Copy link
Member

  • migrate to typescript
  • add tests
  • integrate the heatmap

MaybeJustJames
MaybeJustJames reviewed Aug 30, 2019
View reviewed changes
src/lib/treeviewNode.ts
import { Node } from "./node";

type countAccessorFunction = (n: TreeviewNode) => number;
type nodeData = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TreeView.data is overriding Node.data here. Perhaps it's better to specify a more general Node.data type? Also Node.Data for consistency.

@pverscha
Copy link
Member

This PR has been superseded by #39, #38, #37 and #36.

@pverscha pverscha closed this Feb 16, 2021
@bmesuere bmesuere deleted the 2.0 branch March 9, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaybeJustJames MaybeJustJames MaybeJustJames left review comments

Assignees

@bmesuere bmesuere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmesuere @pverscha @MaybeJustJames